Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change initialHashedPassword to initialPassword #105143

Closed
wants to merge 2 commits into from
Closed

Change initialHashedPassword to initialPassword #105143

wants to merge 2 commits into from
+1 −1

Conversation

victorb
Copy link

@victorb victorb commented Nov 27, 2020

Motivation for this change

Fixing incorrect documentation. As the value is clear text, not hashed, it should use initialPassword instead, otherwise login won't work with the provided password.

Things done
  • Tested locally on nixos via nixos-rebuild build-vm on release 20.09

Sorry, something went wrong.

@victorb
Change initialHashedPassword to initialPassword
ced7458 
As the value is clear text, not hashed, it should use initialPassword instead, otherwise login won't work with the provided password.
@victorb
Remove double-trailing newline
bc2e598 
Thanks GitHub web editor...
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 27, 2020
nh2
nh2 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@nh2
Copy link
Contributor

nh2 commented Nov 30, 2020

Please squash the commits into one.

@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
@Artturin Artturin closed this Oct 11, 2021
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@victorb @nh2 @Artturin @Janik-Haag