Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uwc: Init at 1.0.4 #105144

Merged
merged 1 commit into from Nov 27, 2020
Merged

uwc: Init at 1.0.4 #105144

merged 1 commit into from Nov 27, 2020

Conversation

ShamrockLee
Copy link
Contributor

Motivation for this change

uwc is a Unicode-aware word counter with per-line mode written in Rust
If applied, users will be able to count the
number of unicode characters and words
(e.g. Chinese characters) from files or through the pipe.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
      • NixOnDroid
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (No reverse dependency yet)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (33039552)
  • Ensured that relevant documentation is up to date (No related documentation)
  • Fits CONTRIBUTING.md.

Comment on lines 24 to 25
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final new line to much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I not leave a new line at the bottom of the Nix expression?
Update: It seems that people don't put final new lines in their works. Thanks for reminding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final new line removed.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105144 run on x86_64-linux 1

1 package built:
  • uwc

uwc is a Unicode-aware word counter with per-line mode written in Rust
If applied, users will be able to count the
number of unicode characters and words
(e.g. Chinese characters) from files or through the pipe.
@ShamrockLee
Copy link
Contributor Author

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 27, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 27, 2020
@ShamrockLee
Copy link
Contributor Author

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 27, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105144 run on x86_64-darwin 1

1 package built:
  • uwc

@SuperSandro2000 SuperSandro2000 merged commit 54dd8fb into NixOS:master Nov 27, 2020
@ShamrockLee ShamrockLee deleted the uwc branch November 28, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants