Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rav1e: 0.3.4 -> 0.4.0-alpha // ffmpeg-full: re-enable rav1e #104122

Merged
merged 2 commits into from Nov 19, 2020
Merged

rav1e: 0.3.4 -> 0.4.0-alpha // ffmpeg-full: re-enable rav1e #104122

merged 2 commits into from Nov 19, 2020

Conversation

Chiiruno
Copy link
Contributor

Motivation for this change

Fix #100029

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from primeos November 18, 2020 04:09
primeos
primeos requested changes Nov 18, 2020
View reviewed changes
pkgs/tools/video/rav1e/default.nix Outdated Show resolved Hide resolved
primeos
primeos approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

When I first tried to build it one of the tests failed but the next three builds where fine. Seems like there is some nondeterminism but the chances of that causing a build failure are hopefully pretty low. If this causes problems on Hydra we'll have to disable it in ffmpeg-full, again.

@primeos primeos merged commit 15fb3be into NixOS:master Nov 19, 2020
@Chiiruno Chiiruno deleted the dev/rav1e branch November 19, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rav1e: error adding symbols: file format not recognized
3 participants
@Chiiruno @primeos @Madouura