Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssh: fix hpn sha256 #103803

Merged
merged 1 commit into from Nov 24, 2020
Merged

openssh: fix hpn sha256 #103803

merged 1 commit into from Nov 24, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

https://hydra.nixos.org/build/130304095

Things done

Fixed hpn sha256.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from aneeshusa and edolstra November 14, 2020 12:03
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103803 run on x86_64-darwin 1

1 package built:
  • openssh_hpn

@SuperSandro2000
Copy link
Member

Now is the question why this hash changed.

@ajs124 ajs124 mentioned this pull request Nov 24, 2020
Closed
10 tasks
@ajs124
Copy link
Member

ajs124 commented Nov 24, 2020

According to #104568 they just republished the same tag -.-

@SuperSandro2000
Copy link
Member

According to #104568 they just republished the same tag -.-

I wrote a hopefully friendly message under the commit that they won't do that in the future.

@SuperSandro2000 SuperSandro2000 merged commit 3cd08dc into NixOS:master Nov 24, 2020
@nh2 nh2 mentioned this pull request Dec 28, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshusa aneeshusa Awaiting requested review from aneeshusa

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SCOTT-HAMILTON @SuperSandro2000 @ajs124