wabt: 1.0.19 -> 1.0.20 #103807
Merged
wabt: 1.0.19 -> 1.0.20 #103807
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some unknown reason, the version built here reports itself as 1.0.13 (e.g. in `wasm-objdump --version`). That is unfortunate, but seems to match what happened in the release binaries published on github: - https://github.com/WebAssembly/wabt/releases/tag/1.0.20 these report 1.0.13 for me, too, on macos. - WebAssembly/wabt#1463 Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reason, the version built here reports
itself as 1.0.13 (e.g. in
wasm-objdump --version).That is unfortunate, but seems to match what happened in
the release binaries published on github:
these report 1.0.13 for me, too, on macos.
Motivation for this change
Upstream release.
Things done
❓ I've built this using
nix-env --option sandbox true -i wabt -f .-- is that sufficient for the first checkbox? (Sorry, newbie here.)sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)