Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] bambootracker: 0.4.4 -> 0.4.5 #103808

Merged
merged 1 commit into from Jan 5, 2021
Merged

[20.09] bambootracker: 0.4.4 -> 0.4.5 #103808

merged 1 commit into from Jan 5, 2021

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Nov 14, 2020 •
edited

(cherry picked from commit e940b82)

Motivation for this change

Simple version bump with one dropped dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OPNA2608
bambootracker: 0.4.4 -> 0.4.5
7600bc5 
(cherry picked from commit e940b82)
@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 103808 1

1 package built:
  • bambootracker

Don't know what is the policy for backporting non-critical packages, but it builds and seems to work.

jonringer
jonringer approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/103808

1 package built:
bambootracker

@jonringer jonringer merged commit 7144633 into NixOS:release-20.09 Jan 5, 2021
@OPNA2608 OPNA2608 deleted the update/bambootracker-0.4.5/20.09 branch September 27, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OPNA2608 @thiagokokada @jonringer @FRidh