-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor-reset: init at unstable-2021-02-16 #103816
Conversation
Result of 2 packages marked as broken and skipped:
12 packages failed to build:
5 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restrict it to working kernels.
It's not stated anywhere which kernel versions are supported. I think it should work on any reasonably modern kernel. |
Than restrict the version to exclude the build failures above. |
1e181a9
to
c686907
Compare
Updated PR to vendor-reset version 0.1.0.
I don't think the failures are related to the vendor-reset itself, as it builds fine for some of the "failing" kernel versions locally, but in 19.09 channel. Unfortunately, I can't do nixpkgs-review myself, as it pulls a lot of dependencies. |
Result of 2 packages marked as broken and skipped:
4 packages failed to build:
13 packages built:
|
|
Thanks! I've restricted it to kernels >= 4.19. |
84eefb8
to
2a62de8
Compare
Result of 1 package failed to build:
13 packages built:
|
Rebased and updated to the latest version with a fix for linux 5.11 |
ping @wedens |
I've added the suggestions. |
hey @wedens, thanks for packaging vendor-reset. i just ran nixpkgs-review again: Result of 7 packages marked as broken and skipped:
13 packages built:
does this resolve the change-request, @SuperSandro2000? |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)