Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 0.5.0 -> 0.6.0-rc1 #103817

Merged
merged 1 commit into from Nov 18, 2020
Merged

alacritty: 0.5.0 -> 0.6.0-rc1 #103817

merged 1 commit into from Nov 18, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 14, 2020 •
edited

Motivation for this change

Fix #103785 .

0.5.0 doesn't work with gnome 3.38 which is currently on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cole-h, Mic92 and Ma27 November 14, 2020 16:28
cole-h
cole-h approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

prusnak
prusnak approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

@cole-h
Copy link
Member

cole-h commented Nov 15, 2020

rc2 was just released, maybe bump to that since this hasn't been merged yet? :D

@Mic92
Copy link
Member

Mic92 commented Nov 15, 2020 •
edited

It was released 2h ago and their release ci failed: https://github.com/alacritty/alacritty/actions/runs/363815045

@cole-h
Copy link
Member

cole-h commented Nov 15, 2020

(It failed on Windows)

@prusnak
Copy link
Member

prusnak commented Nov 15, 2020 •
edited

(It failed on Windows)

Yes, it seems only the Windows packaging step is broken in the CI (the installer does not like the -rc2 in the version, so I assume this was broken also for -rc1).

OTOH maybe 0.6.0 will be released soon if time between rc1 and rc2 was only one day.

@doronbehar
Copy link
Contributor Author

Yea they also said it will take a week if no surprises will be introduced, I'm kind of satisfied with this change in my fork so 🤷. I'll try to remember to update it to 0.6.0 as soon as possible.

@Mic92
Copy link
Member

Mic92 commented Nov 16, 2020

rc2 is now official released: https://github.com/alacritty/alacritty/releases/tag/v0.6.0-rc2

Br1ght0ne
Br1ght0ne approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@doronbehar
Copy link
Contributor Author

I'm merging this as is, since it's a bit urgent I suppose for Gnome users and 0.6.0 should come in a few days and the diff between rc1 -> rc2 is not that big.

@doronbehar doronbehar merged commit 0365749 into NixOS:master Nov 18, 2020
@doronbehar doronbehar deleted the pkg/alacritty branch November 18, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@cole-h cole-h cole-h approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we update alacritty to 0.6.0rc-1?
5 participants
@doronbehar @cole-h @Mic92 @prusnak @Br1ght0ne