Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ulogd: init at 2.0.7 #103804

Closed
wants to merge 4 commits into from
Closed

ulogd: init at 2.0.7 #103804

wants to merge 4 commits into from

Conversation

xvuko
Copy link
Contributor

@xvuko xvuko commented Nov 14, 2020 •
edited

Motivation for this change

ulogd is a userspace logging daemon for netfilter/iptables related logging. This includes per-packet logging of security violations, per-packet logging for accounting, per-flow logging and flexible user-defined accounting.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xvuko xvuko force-pushed the ulogd branch 2 times, most recently from 28785e0 to 2ad0733 Compare November 14, 2020 12:18
aanderse
aanderse previously requested changes Nov 14, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at your module and had a few suggestions. I hope you find them helpful. If you have any questions or need any help don't hesitate to ask.

nixos/modules/services/logging/ulogd.nix Outdated Show resolved Hide resolved
nixos/modules/services/logging/ulogd.nix Outdated Show resolved Hide resolved
nixos/modules/services/logging/ulogd.nix Outdated Show resolved Hide resolved
@xvuko
Copy link
Contributor Author

xvuko commented Nov 16, 2020

@aanderse Thanks for suggestions! I have added them to my commits.

In order to build docs I added another package: linuxdoc-tools. Is it OK to add it here, or should I open another PR?

aanderse
aanderse reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with ulogd and I don't generally review packages, but the module part of this PR looks good to me 👍

@aanderse aanderse dismissed their stale review November 19, 2020 12:13

The module looks good, but I don't generally review packages.

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@alexvorobiev
Copy link
Contributor

@xvuko I am interested in linuxdoc-tools. Did you consider separating it to another PR?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@p-h p-h mentioned this pull request Dec 23, 2022
Merged
13 tasks
@RaitoBezarius
Copy link
Member

RaitoBezarius commented Dec 30, 2022 •
edited

Done in #207453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xvuko @alexvorobiev @RaitoBezarius @aanderse @SuperSandro2000 @Janik-Haag