Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] slack: 4.8.0 -> 4.10.3 #103789

Merged
merged 1 commit into from Nov 21, 2020
Merged

[20.09] slack: 4.8.0 -> 4.10.3 #103789

merged 1 commit into from Nov 21, 2020

Conversation

JesusMtnez
Copy link
Contributor

@JesusMtnez JesusMtnez commented Nov 14, 2020 •
edited

Motivation for this change

Bump to latest slack release

(cherry picked from commit fdc5b32)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JesusMtnez
slack: 4.9.0 -> 4.10.3
ba3e17d 
(cherry picked from commit fdc5b32)
@Mic92 Mic92 mentioned this pull request Nov 14, 2020
Closed
@ofborg ofborg bot requested a review from mmahut November 14, 2020 09:55
@cyplo
Copy link
Contributor

cyplo commented Nov 14, 2020

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build

@JesusMtnez
Copy link
Contributor Author

What else could I do to move this forward?

@stigtsp
Copy link
Member

stigtsp commented Nov 20, 2020

@GrahamcOfBorg build slack

@stigtsp
Copy link
Member

stigtsp commented Nov 20, 2020 •
edited

This PR should include latest updates from master #103954

@FRidh FRidh merged commit c35916e into NixOS:release-20.09 Nov 21, 2020
@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

updated to 4.11.1 with fa06e69.

@JesusMtnez JesusMtnez deleted the backport branch February 22, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JesusMtnez @cyplo @stigtsp @FRidh