Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq_8_12: 8.12.0 → 8.12.1 #103787

Merged
merged 1 commit into from Nov 15, 2020
Merged

coq_8_12: 8.12.0 → 8.12.1 #103787

merged 1 commit into from Nov 15, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 14, 2020

Motivation for this change

A few fixes: https://coq.github.io/doc/V8.12.1/refman/changes.html#changes-in-8-12-1

cc maintainers @roconnor @thoughtpolice @Zimmi48

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Zimmi48
Zimmi48 approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@enolan
Copy link
Contributor

enolan commented Nov 15, 2020

coqide launches successfully and coqc --version works.

@vbgl vbgl merged commit 2806eb2 into NixOS:master Nov 15, 2020
@vbgl vbgl deleted the coq-8.12.1 branch November 15, 2020 11:03
@vbgl
Copy link
Contributor Author

vbgl commented Nov 15, 2020

Merged into 20.09 as 9be6b03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

@roconnor roconnor Awaiting requested review from roconnor

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: coq 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @enolan @Zimmi48