Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sof-firmware: 1.5.1 -> 1.6 #103778

Merged
merged 1 commit into from Dec 2, 2020
Merged

sof-firmware: 1.5.1 -> 1.6 #103778

merged 1 commit into from Dec 2, 2020

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Nov 14, 2020 •
edited

Motivation for this change

Bump to latest stable, hopefully more stable than version before. Testing it on X1 carbon gen7.

cc @zuigon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

evenbrenden
evenbrenden approved these changes Nov 14, 2020
View reviewed changes
Copy link
Contributor

@evenbrenden evenbrenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested basic audio I/O on a ThinkPad X1 Carbon Gen 7 with nixpkgs at 84d74ae9c9.

@lblasc
Copy link
Contributor Author

lblasc commented Nov 17, 2020

Unfortunately on kernels > 5.9.3 microphone is broken either on 1.5.1 or 1.6.

@lblasc
Copy link
Contributor Author

lblasc commented Nov 21, 2020

Bump sof-frimware to official 1.6 release. Microphone now works (kernel 5.9.9) ! I had to play a little bit with pavucontrol.

@ofborg ofborg bot requested a review from evenbrenden November 21, 2020 15:52
@lblasc
Copy link
Contributor Author

lblasc commented Nov 30, 2020

After one week of extensive testing (jitsi calls) I didn't found any issues.

Pinging random people.. @SuperSandro2000 can you please merge this one.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103778 run on x86_64-linux 1

1 package built:
  • sof-firmware

@SuperSandro2000 SuperSandro2000 merged commit 3a5fe2e into NixOS:master Dec 2, 2020
@lblasc lblasc deleted the sof-firmware-16 branch December 2, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenbrenden evenbrenden evenbrenden approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lblasc @SuperSandro2000 @evenbrenden