pytest-testmon: skip broken tests #103786
Conversation
For some reason the v1.0.3 PyPI tarball ships with tests that expect pytest-testmon master instead of the v1.0.3 code. tarpas/pytest-testmon#158
|
Wouldn't it be better to wait for this issue to be sorted upstream before we included this (broken?) version in the nixpkgs? |
|
Afaict the package itself is not broken, just the wrong version of the tests (assuming a commit after v1.0.3) were included.
I'm also fine with downgrading back to 1.0.2, but tbqh that sounds more risky to me, not less.
…On 14 November 2020 10:44:17 CET, Daniel Vianna ***@***.***> wrote:
Wouldn't it be better to wait for this issue to be sorted upstream before we included this (broken?) version in the nixpkgs?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#103786 (comment)
|
|
If they're using semantic versioning, there would be no change in the API. I would not feel comfortable installing a test suite for which its own tests are failing. How would you know the library is functioning as expected and bugs were not introduced between 1.0.2 and 1.0.3? |
Looks like they're not...
I agree it's a pretty bad look
I manually inspected the test failures, and they are all failing because 1.0.3 does not contain the changes from the post-1.0.3 tarpas/pytest-testmon@cfb7c2d commit, which seem backwards-compatible.
That works for me as well, #103958 |
|
(in fact I don't really care which solution we choose, I just want staging to build without failures again ;) ) |
Motivation for this change
For some reason the v1.0.3 PyPI tarball ships with tests that expect pytest-testmon master instead of the v1.0.3 code (tarpas/pytest-testmon#158), causing these tests to fail against 1.0.3 itself.
nixpkgs-reviewon unrelated PR's to staging currently fail because the tests for this package fail.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)