Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archivy: init at 0.8.5 #103815

Merged
merged 2 commits into from Nov 30, 2020
Merged

archivy: init at 0.8.5 #103815

merged 2 commits into from Nov 30, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Nov 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Nov 14, 2020

@GrahamcOfBorg build archivy

@siraben siraben changed the title archivy: init at 0.8.1 archivy: init at 0.8.2 Nov 15, 2020
@rmcgibbo
Copy link
Contributor

I built this with nix-review pr 103815, and was able to open executable and start the application in the browser. LGTM.

@siraben
Copy link
Member Author

siraben commented Nov 18, 2020

Result of nixpkgs-review pr 103815 1

4 packages built:
  • archivy
  • python27Packages.python-frontmatter
  • python37Packages.python-frontmatter
  • python38Packages.python-frontmatter

@siraben siraben force-pushed the archivy-init branch 2 times, most recently from b0ab6f6 to f7589d1 Compare November 19, 2020 08:19
@siraben siraben changed the title archivy: init at 0.8.2 archivy: init at 0.8.4 Nov 19, 2020
@siraben
Copy link
Member Author

siraben commented Nov 25, 2020

Result of nixpkgs-review pr 103815 1

1 package failed to build:
  • archivy
1 package built:
  • python27Packages.python-frontmatter (python37Packages.python-frontmatter ,python38Packages.python-frontmatter)

@siraben
Copy link
Member Author

siraben commented Nov 25, 2020 •
edited

Looks like python3Packages.pypandoc is failing to build.

Build log 
builder for '/nix/store/kp5qmxrq5rvpiqy42830lbmzbshfgz5q-python3.8-isort-4.3.21.drv' failed with exit code 1; last 10 log lines:
  >           assert str(tmpdir.join("file1.py")) in out
  E           AssertionError: assert '/private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0/file1.py' in 'Fixing /private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0/file2.py\n'
  E            +  where '/private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0/file1.py' = str(local('/private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0/file1.py'))
  E            +    where local('/private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0/file1.py') = <bound method LocalPath.join of local('/private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0')>('file1.py')
  E            +      where <bound method LocalPath.join of local('/private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0')> = local('/private/tmp/pytest-of-siraben/pytest-2/test_command_line_True_0').join
  
  /private/tmp/nix-build-python3.8-isort-4.3.21.drv-0/isort-4.3.21/test_isort.py:2759: AssertionError
  =========================== short test summary info ============================
  FAILED test_isort.py::test_command_line[True] - AssertionError: assert '/priv...
  ================= 1 failed, 153 passed, 2 deselected in 5.57s ==================
cannot build derivation '/nix/store/0nsqjf5b1hk26syc33k0wr9zm0ygabqq-python3.8-poetry-core-1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1jahrni7z0x2zr4pii0ajyjkvhl637hw-python3.8-validators-0.17.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2acjmf3z78wxw6yw71g5wp8jgsdf915m-python3.8-poetry-1.1.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kjf1vfwmymg79q6mnxg0c50pn054b62w-python3.8-tinydb-4.1.1.drv': 1 dependencies couldn't be built
builder for '/nix/store/bx8w80rv5gma0pkkvjr3afic7zjxkaaq-python3.8-pypandoc-1.5.drv' failed with exit code 1; last 10 log lines:
  ?       -
  + # üäöîôû? ++
  - ======
  
  ----------------------------------------------------------------------
  Ran 24 tests in 8.572s
  
  FAILED (failures=1, skipped=1)
  Test failed: <unittest.runner.TextTestResult run=24 errors=0 failures=1>
  error: Test failed: <unittest.runner.TextTestResult run=24 errors=0 failures=1>
cannot build derivation '/nix/store/fw65fhfd2kj608zswfhyw1nk8ai1jb5x-archivy-0.8.4.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5kf5i03yg4bfqf5ak3diprkbrcq6w6c9-env.drv': 1 dependencies couldn't be built

@siraben
Copy link
Member Author

siraben commented Nov 26, 2020

Looks like pypandoc tests failing would be fixed by #104625

@siraben siraben changed the title archivy: init at 0.8.4 archivy: init at 0.8.5 Nov 27, 2020
@siraben
Copy link
Member Author

siraben commented Nov 27, 2020

Result of nixpkgs-review pr 103815 1

2 packages built:
  • archivy
  • python27Packages.python-frontmatter (python37Packages.python-frontmatter ,python38Packages.python-frontmatter)

@infinisil infinisil merged commit c1b1af0 into NixOS:master Nov 30, 2020
@siraben siraben deleted the archivy-init branch December 1, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siraben @rmcgibbo @jonringer @infinisil