Why not build with Qt 5.15?

My Pull Request doesn't aim at fixing elisa build against Qt5.15 (which it doesn't need anyway as the last build on staging-20.09 tells).
I just propose this pull request to fix elisa builds against Qt < 5.14 (in nixpkgs case, builds against Qt5.14)

The hydra build you linked passed. Maybe the bug was somewhere else and fixed in the meanwhile?

Could you link to the successful build? I can't find it.

I too don't understand exactly why apply that patch. Currently elisa fails to launch for me with:

QQmlApplicationEngine failed to load component
qrc:/qml/ElisaMainWindow.qml:175:13: Type HeaderBar unavailable
qrc:/qml/HeaderBar.qml:11:1: module "QtGraphicalEffects" is not installed

And applying this patch makes it work:

diff --git i/pkgs/applications/kde/elisa.nix w/pkgs/applications/kde/elisa.nix
index 9a51aa786fa..ee45202fe54 100644
--- i/pkgs/applications/kde/elisa.nix
+++ w/pkgs/applications/kde/elisa.nix
@@ -7,6 +7,7 @@
 , qtmultimedia
 , qtquickcontrols2
 , qtwebsockets
+, qtgraphicaleffects
 , kconfig
 , kcmutils
 , kcrash
@@ -36,6 +37,7 @@ mkDerivation rec {
     kirigami2
     qtmultimedia
     qtquickcontrols2
+    qtgraphicaleffects
     qtwebsockets
   ];
 

Though I don't understand why use propagatedBuildInputs and not normal buildInputs..

Elisa works fine here (on unstable). Can somebody please explain exactly what isn't working?

This is just to fix elisa build on Qt < 5.15. Qt 5.15 is the default verision for libsForQt5 on unstable, so it won't change anything for you. But people running older channels might be interested in using libsForQt5{12,14}.elisa which is the default when installing elisa on older channels.

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 103802 run on x86_64-linux 1

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

libsForQt5.elisa.log:

   |
53 |     license = licenses.gpl3;
   |     ^

This is just to fix elisa build on Qt < 5.15. Qt 5.15 is the default verision for libsForQt5 on unstable, so it won't change anything for you. But people running older channels might be interested in using libsForQt5{12,14}.elisa which is the default when installing elisa on older channels.

Then @SCOTT-HAMILTON please make the PR target the older branch that you'd like elisa to build with there.

QQmlApplicationEngine failed to load component
qrc:/qml/ElisaMainWindow.qml:175:13: Type HeaderBar unavailable
qrc:/qml/HeaderBar.qml:11:1: module "QtGraphicalEffects" is not installed

And applying this patch makes it work:

diff --git i/pkgs/applications/kde/elisa.nix w/pkgs/applications/kde/elisa.nix
index 9a51aa786fa..ee45202fe54 100644
--- i/pkgs/applications/kde/elisa.nix
+++ w/pkgs/applications/kde/elisa.nix
@@ -7,6 +7,7 @@
 , qtmultimedia
 , qtquickcontrols2
 , qtwebsockets
+, qtgraphicaleffects
 , kconfig
 , kcmutils
 , kcrash
@@ -36,6 +37,7 @@ mkDerivation rec {
     kirigami2
     qtmultimedia
     qtquickcontrols2
+    qtgraphicaleffects
     qtwebsockets
   ];
 

Problems with missing QtGraphicalEffects in application using Kirigami may have been fixed in unstable by #108331.

I marked this as stale due to inactivity. → More info

I'm closing due to this being irrelevant now.