Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eduke32: 20190330 -> 20200907 #103797

Merged
merged 1 commit into from Nov 21, 2020
Merged

eduke32: 20190330 -> 20200907 #103797

merged 1 commit into from Nov 21, 2020

Conversation

thblt
Copy link
Contributor

@thblt thblt commented Nov 14, 2020

Update eduke32 to latest version. I've had to add alsaLib to
buildInputs, but I assume the system provides it at runtime, so
there's no need to make it a full runtime dependency. To make sure,
I've tried to run the game after nix-collect-garbage, and it worked.

@thblt
Copy link
Contributor Author

thblt commented Nov 14, 2020

Sorry, I sent the PR from Forge and it lacked the template.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from svanderburg November 14, 2020 11:10
@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

@GrahamcOfBorg build eduke32

@FRidh FRidh merged commit 7798a4e into NixOS:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siraben siraben siraben left review comments

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thblt @FRidh @siraben