pysim: Run mask on Mux selection operand. #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 81.43% 81.43%
=======================================
Files 49 49
Lines 6464 6464
Branches 1290 1290
=======================================
Hits 5264 5264
Misses 1010 1010
Partials 190 190
Continue to review full report at Codecov.
|
whitequark
reviewed
Nov 14, 2020
Otherwise it behaves funny when it's eg. the result of operator ~.
mwkmwkmwk
force-pushed
the
mwk/mux-fix
branch
from
7aa3f03
to
63766fa
Compare
|
Added a test; It seems we should have all operators go through similar treatment though, to avoid similar problems. |
The original idea was to use |
whitequark
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it behaves funny when it's eg. the result of operator ~.