nixos/firejail: allow to pass options to firejail #103813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigtsp
reviewed
Nov 18, 2020
Comment on lines
+45
to
+50
| profile = mkOption { | ||
| type = types.nullOr types.path; | ||
| default = null; | ||
| description = "Profile to use"; | ||
| example = literalExample "''${pkgs.firejail}/etc/firejail/firefox.profile"; | ||
| }; |
There was a problem hiding this comment.
Would it make sense to have profile as a string instead so it's possible to do profile="firefox" for instance?
There was a problem hiding this comment.
this would prevent profile = pkgs.writeText "name" "content"
There was a problem hiding this comment.
Does this answer satisfy you?
There was a problem hiding this comment.
Sorry forgot this PR, yes that was a use-case I didn't consider. :)
|
@GrahamcOfBorg build firejail.tests |
|
Looks good to me, @7c6f434c can you have a look as well? |
|
@GrahamcOfBorg test firejail |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow to select a profile for binaries wrapped with firejail
This is backward compatible, as shown by the nixos test
cc @stigtsp
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)