New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccache: 3.7.12 -> 4.0 #104425
ccache: 3.7.12 -> 4.0 #104425
Conversation
I don't have a mac to test this on. Can a trusted user of ofborg run a build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need ccache/ccache#694 to build on darwin as we're still on SDK 10.12
@r-burns Ok thank you! I've added the patch. |
I'm getting a lot of failures because their tests seem to be assuming macOS implies XCode and AppleClang etc. So it might make sense to just use the non-apple pathway since our stdenv is closer to Linux/BSD than Apple tools.
However, some tests are still failing:
Full log:
|
@r-burns Thanks again!
I think we can just add |
For some reason adding But I am able to fix
Btw, feel free to add me as a maintainer and I'll help out with the darwin story in the future. |
@r-burns I added the patches, disabled the 3 remaining tests, and added you as a maintainer. Does this look good to you? |
Looks great! I'll run it through the nixpkgs-review gauntlet and see if I run into any more issues. |
@r-burns Thank you so much for your help, and volunteering to be a maintainer 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r-burns It looks like |
Yeah, that's definitely better -
nocpp2 and modules seem to have the same failure as before, debug_prefix_map is using the HOST_OS_APPLE path and I guess our xcrun doesn't have dwarfdump. |
Oh, it looks like xcrun is just a wrapper script: nixpkgs/pkgs/development/tools/xcbuild/wrapper.nix Lines 53 to 80 in dd33b30
dwarfdump to checkInputs ?
|
We don't package dwarfdump on darwin - I tried getting it to work but it seems nontrivial. I'll keep looking as I think that would ultimately be the best approach, but I wouldn't want that to hold up this update. |
Yeah, it seems like |
Oh oops, I left out |
Additional changes: - Added myself as a maintainer - Generalized ccacheStdenv to allow overriding stdenv
ccache build is disabled with CCACHE_DISABLE=1, so it's unnecessary
ccache just adds unnecessary overhead when building in a sandboxed environment
Result of 2 packages built:
|
@ElXreno Thanks for reporting this! I intended to make |
Motivation for this change
Upgrade to the latest version: https://github.com/ccache/ccache/releases/tag/v4.0
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Removed as a build dependency of baresip & webbrowser:
./result/bin/
)nix path-info -S
before and after)