Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: add extraSANs to kubelet TLS cert. #104408

Closed
wants to merge 0 commits into from
Closed

nixos/kubernetes: add extraSANs to kubelet TLS cert. #104408

wants to merge 0 commits into from
+0 −0

Conversation

juselius
Copy link
Contributor

Motivation for this change

Allow adding extra (IP) SANs to the kubelet TLS cert. Running services
like metrics-server in secure mode tries to access kubelet over https
using the node IP. If the the certificate does not contain the correct
IP SANs, metrics server fails (unless started with--kubelet-insecure-tls).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 20, 2020
@rissson
Copy link
Member

rissson commented Nov 23, 2020

Looks good to me.

johanot
johanot approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@johanot johanot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert I'm good with this. You? :)

saschagrunert
saschagrunert approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anmonteiro
anmonteiro reviewed Feb 10, 2021
View reviewed changes
nixos/modules/services/cluster/kubernetes/kubelet.nix Outdated
extraSANs = mkOption {
description = "Extra x509 Subject Alternative Names to be added to the kubelet tls cert.";
default = [];
type = listOf str;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add an example, please? like I did in #74094

@stale
Copy link

stale bot commented Aug 10, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2021
@anmonteiro
Copy link
Member

Not stale.....

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2021
@juselius juselius closed this Sep 16, 2021
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro

@saschagrunert saschagrunert

@johanot johanot

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juselius @rissson @anmonteiro @saschagrunert @johanot