Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] python3.pkgs.pipInstallHook: don't warn on script installation #104411

Merged
merged 1 commit into from Nov 20, 2020
Merged

[staging] python3.pkgs.pipInstallHook: don't warn on script installation #104411

merged 1 commit into from Nov 20, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 20, 2020 •
edited

Motivation for this change

we don't have $out/bin on the PATH when installing scripts, so pip will issue a warning:

master:

Installing collected packages: pip
  WARNING: The scripts pip, pip3 and pip3.8 are installed in '/nix/store/kv23pa2s08mljd4fyl6gl8hdhgfpkgjg-python3.8-pip-20.2.4/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed pip-20.2.4

this PR:

Installing collected packages: pip
Successfully installed pip-20.2.4
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/working-directory-for-python-script/9598/9

FRidh
FRidh approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just put it on PATH, also considering tests. I don't know what the best solution is, but indeed we should get rid of this warning.

@jonringer
Copy link
Contributor Author

Maybe we should just put it on PATH, also considering tests. I don't know what the best solution is, but indeed we should get rid of this warning.

I'm not really sure what would be "expected behavior"

@jonringer
Copy link
Contributor Author

going to merge when ofborg is finished

@jonringer jonringer merged commit 8d210e2 into NixOS:staging Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @nixos-discourse @FRidh