busybox: 1.31.1 -> 1.32.0 #104433
Merged
busybox: 1.31.1 -> 1.32.0 #104433
+2
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. It is a (hopefully simple) version bump with two patches removed. What I've tested that:
|
rissson
added
10.rebuild-linux: 1-10
10.rebuild-linux: 11-100
10.rebuild-linux: 1
8.has: package (update)
|
Result of 2 packages marked as broken and skipped:
2 packages failed to build:
60 packages built:
|
|
It's weird |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
|
This is mostly replicable on my system: Result of 1 package marked as broken and skipped:
2 packages blacklisted:
3 packages failed to build:
62 packages built:
However I as far as I can tell |
|
It seems alright to merge though. @j4m3s-s do you have any time to look into why those few dependencies fail, if they weren't broken on master before? |
r-burns
approved these changes
Jan 2, 2021
There was a problem hiding this comment.
python37Packages.nixpkgs is broken due to python37Packages.pythonix, which builds but fails to import on non-python-3.8 (see #103151 (comment)). I think this is ready to be merged.
Result of nixpkgs-review pr 104433 1
1 package marked as broken and skipped:
- nix-exec
2 packages blacklisted:
- tests.nixos-functions.nixos-test
- tests.nixos-functions.nixosTest-test
1 package failed to build:
- python37Packages.nixpkgs
64 packages built:
- bundix
- busybox
- busybox-sandbox-shell
- cabal2nix
- cachix
- common-updater-scripts
- crate2nix
- crystal2nix
- dep2nix
- disnix
- disnixos
- epson-escpr2
- fcron
- fusionInventory
- go2nix
- haskellPackages.cachix
- haskellPackages.hocker
- haskellPackages.nix-paths
- haskellPackages.update-nix-fetchgit
- hydra-unstable
- lazpaint
- lightdm
- lightdm-enso-os-greeter
- lightdm-mini-greeter
- lightdm-tiny-greeter
- lightdm_gtk_greeter
- lightdm_qt
- lispPackages.quicklisp-to-nix
- lispPackages.quicklisp-to-nix-system-info
- molly-guard
- nix (nixStable)
- nix-bundle
- nix-direnv
- nix-doc
- nix-du
- nix-index
- nix-pin
- nix-plugins
- nix-prefetch
- nix-prefetch-bzr
- nix-prefetch-cvs
- nix-prefetch-docker
- nix-prefetch-git
- nix-prefetch-hg
- nix-prefetch-scripts
- nix-prefetch-svn
- nix-serve
- nix-update
- nix-update-source
- nixFlakes (nixUnstable)
- nixos-generators
- nixos-shell
- nixpkgs-review
- nixui
- pantheon.elementary-greeter
- pipework
- python37Packages.nix-kernel
- python37Packages.pythonix
- python38Packages.nix-kernel
- python38Packages.nixpkgs
- python38Packages.pythonix
- update-nix-fetchgit
- vgo2nix
- vulnix
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package marked as broken and skipped:
2 packages blacklisted:
3 packages failed to build and are new build failures:
62 packages built:
The following issues got detected with the above build packages. python38Packages.nixpkgs: Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
|
|
All build failures are known and unrelated to this PR. |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
The patches removed are on the 1.32.0 branch now.
Building works and
nix-build pkgs/stdenv/linux/make-bootstrap-tools.nix -A testalso works as asked in the file.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)