Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supercollider: 3.11.0 -> 3.11.2 #104431

Merged
merged 1 commit into from Nov 23, 2020
Merged

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 20, 2020

Motivation for this change

This update allows to migrate to Qt5.15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor Author

Related to #104474

@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

@GrahamcOfBorg eval

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104431 1

6 packages built:
  • python27Packages.foxdot
  • python37Packages.foxdot
  • python38Packages.foxdot
  • sonic-pi
  • supercollider
  • supercollider_scel

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104431 1

6 packages built:
  • python27Packages.foxdot
  • python37Packages.foxdot
  • python38Packages.foxdot
  • sonic-pi
  • supercollider
  • supercollider_scel

@jonringer jonringer merged commit cfba07b into NixOS:master Nov 23, 2020
@freezeboy freezeboy deleted the migrate-supercollider branch November 23, 2020 15:12
@OPNA2608 OPNA2608 mentioned this pull request Mar 23, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants