Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutt: 2.0.1 -> 2.0.2 #104399

Merged
merged 1 commit into from Nov 20, 2020
Merged

mutt: 2.0.1 -> 2.0.2 #104399

merged 1 commit into from Nov 20, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
mutt: 2.0.1 -> 2.0.2
ad9256d 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@ofborg ofborg bot requested a review from rnhmjoj November 20, 2020 18:38
rnhmjoj
rnhmjoj approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: it's just a security bug fix.

stigtsp
stigtsp approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104399 1

2 packages built:
  • grepm
  • mutt (mutt-with-sidebar)

@stigtsp stigtsp merged commit 5741294 into NixOS:master Nov 20, 2020
@stigtsp
Copy link
Member

stigtsp commented Nov 20, 2020

This needs backport to 20.09 and 20.03 to fix CVE-2020-28896

@stigtsp stigtsp mentioned this pull request Nov 20, 2020
Merged
10 tasks
@stigtsp
Copy link
Member

stigtsp commented Nov 20, 2020

I'll fix the backports

@Ma27
Copy link
Member

Ma27 commented Nov 20, 2020

cc @rnhmjoj mutt 2.x isn't on 20.09, but this release is security relevant. Any ideas how to proceed?

This was referenced Nov 20, 2020
Merged
Closed
@matthiasbeyer matthiasbeyer deleted the update-mutt branch November 22, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthiasbeyer @stigtsp @Ma27 @rnhmjoj