Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meme: 2017-09-10 -> 2020-05-28 #104398

Merged
merged 1 commit into from Dec 7, 2020
Merged

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Nov 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you mention in the commit that you changed it to buildGoModule?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104398 run on x86_64-linux 1

1 package built:
  • meme

@fgaz
Copy link
Member Author

fgaz commented Dec 2, 2020

@SuperSandro2000 done

pkgs/applications/graphics/meme/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/meme/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104398 run on x86_64-linux 1

1 package built:
  • meme

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104398 run on x86_64-darwin 1

1 package built:
  • meme

@SuperSandro2000 SuperSandro2000 merged commit 1098a0b into NixOS:master Dec 7, 2020
@fgaz fgaz deleted the meme/2020-05-28 branch December 7, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants