Skip to content

python3Packages.tensorflow_2: 2.3.0 -> 2.3.1 #104400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2020
Merged

python3Packages.tensorflow_2: 2.3.0 -> 2.3.1 #104400

merged 1 commit into from
Nov 20, 2020
+4 −10

Conversation

OmnipotentEntity
Copy link
Contributor

Motivation for this change

Update to latest version of Tensorflow (owing to memory leaks and closed CVEs)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@OmnipotentEntity
Copy link
Contributor Author

Because ML software in nix is currently in an awful state, I fully expect everything to break on this point release update, because of course it will.

I have tested only that it builds with CUDA 11, and that the derivation has the correct sha for the non CUDA build.

The removed patch was removed because it is merged in this version.

@ofborg ofborg bot requested a review from abbradar November 20, 2020 18:33
jonringer
jonringer reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python3Packages.tensorflow_2: 2.3.0 -> 2.3.1

@jonringer
Copy link
Contributor

jonringer commented Nov 20, 2020 •
edited
Loading

Because ML software in nix is currently in an awful state, I fully expect everything to break on this point release update, because of course it will.

ML software in general is in an awful state. There's reasons why Anaconda is a multi-million dollar company, and it's main focus is attempting to make ML not suck.

@jonringer
Copy link
Contributor

LGTM after commit message changes

https://github.com/NixOS/nixpkgs/pull/104400
4 packages built:
python37Packages.mask-rcnn python37Packages.tensorflow_2 python38Packages.mask-rcnn python38Packages.tensorflow_2

@OmnipotentEntity OmnipotentEntity changed the title Tensorflow 2.3.0 -> 2.3.1 python3Packages.tensorflow_2: 2.3.0 -> 2.3.1 Nov 20, 2020
@OmnipotentEntity
Copy link
Contributor Author

in your case, the commit message should be:

python3Packages.tensorflow_2: 2.3.0 -> 2.3.1

d'oh. Fixed.

@jonringer jonringer merged commit 5c9e2ff into NixOS:master Nov 20, 2020
@OmnipotentEntity OmnipotentEntity deleted the tensorflow-2.3.1 branch November 20, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

@abbradar abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OmnipotentEntity @jonringer