New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staticjinja: enable tests; lift to top level #104401
Conversation
bb68de4
to
0daf133
Compare
Result of 2 packages built:
|
Result of 2 packages built:
|
0daf133
to
e5fd658
Compare
however, the tool will import the Python code one wrote which imports other modules. I think its a bad idea to expose this one as top-level attribute and think that it should always be considered as part of a Python environment that has all the modules that one uses in a staticjinja project. Or are you saying one never uses additional Python libraries with staticjinja? |
@FRidh I'm saying there's two ways of using this library/program
Having the executable at the top level facilitates the second, simpler, way edit: to be clear, in (2), one does not write python code to generate the site, but only jinja templates, which afaik can't import python code by themselves |
I understand, but would you argue that one typically does so without any additional Python libraries being used aside from those required by staticjinja? |
I'm not sure I understand, could you make an example of using some python library together with staticjinja (the executable), and having the second interfere with the first? I typically just do something like this (taken from the README):
Basically I just use it as a simple way to run a template engine. As far as I can see there isn't even a way to use additional python libraries when running it like this. |
Okay, I see. I mostly skimmed through the advanced section, thinking that becomes pretty essential considering the basic functionality is so limited. |
It depends. If you don't have to load external data (ex. for building simple sites, or for prototyping or reworking a bunch of existing pages) it's surprisingly powerful. If you prefer I can remove the second commit though. |
Ping |
e5fd658
to
f896abb
Compare
and: * fetch from github (tests on pypi get somehow disabled) * formatting
Most user will probably use the cli tool
f896abb
to
52228da
Compare
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages built:
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages built:
|
Motivation for this change
Lifted to the top level because most users will probably use the cli tool
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)