Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottom: 0.4.7 -> 0.5.1 #104444

Merged
merged 1 commit into from Nov 25, 2020
Merged

bottom: 0.4.7 -> 0.5.1 #104444

merged 1 commit into from Nov 25, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Nov 21, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you rebase this branch on master to fix the eval error?

@magnetophon
Copy link
Member Author

Done, also upgraded to the new release.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104444 1

1 package built:
  • bottom

@magnetophon magnetophon changed the title bottom: 0.4.7 -> 0.5.0 bottom: 0.4.7 -> 0.5.1 Nov 24, 2020
@berbiche
Copy link
Member

@SuperSandro2000 do you know why I wasn't automatically pinged as the maintainer?

@RaghavSood RaghavSood merged commit f9d71bf into NixOS:master Nov 25, 2020
@magnetophon magnetophon deleted the bottom branch November 25, 2020 19:03
@SuperSandro2000
Copy link
Member

@SuperSandro2000 do you know why I wasn't automatically pinged as the maintainer?

IIRC you need to be a member of the org to be pinged via githubs reviewer feature through borg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants