Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lc3tools: init at 0.12 #104450

Merged
merged 1 commit into from Nov 29, 2020
Merged

lc3tools: init at 0.12 #104450

merged 1 commit into from Nov 29, 2020

Conversation

anna328p
Copy link
Member

Motivation for this change

Added the lc3tools toolchain and emulator for the LC-3 architecture.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@anna328p
Copy link
Member Author

I think ofborg is broken?

@SuperSandro2000
Copy link
Member

I think ofborg is broken?

Try rebasing on master to catch f75c875

@anna328p
Copy link
Member Author

I think ofborg is broken?

Try rebasing on master to catch f75c875

@SuperSandro2000 Done

@anna328p
Copy link
Member Author

...still seems broken

@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

This is a regression, someone pushed a change that broke evaluation.

@FRidh FRidh mentioned this pull request Nov 21, 2020
Closed
@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

@GrahamcOfBorg eval

1 similar comment
@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

@GrahamcOfBorg eval

@anna328p
Copy link
Member Author

rebased and checks pass now!

SuperSandro2000
SuperSandro2000 reviewed Nov 23, 2020
View reviewed changes
pkgs/development/tools/lc3tools/default.nix
version = "0.12";

src = fetchurl {
url = "https://highered.mheducation.com/sites/dl/free/0072467509/104652/lc3tools_v12.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any URL which uses the version? Otherwise auto updates do not work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There hasn't been an update since 2008. I can potentially ask Lumetta for newer source (he's my professor).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what to do here but packaging software from 2008 does not feel right to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it still builds, why not?

Ma27
Ma27 requested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm actually fine with adding the package itself, please make sure that the executables are installed into $out/bin.

@anna328p
Copy link
Member Author

While I'm actually fine with adding the package itself, please make sure that the executables are installed into $out/bin.

Done.

@Ma27 Ma27 merged commit 91e6ee0 into NixOS:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anna328p @SuperSandro2000 @FRidh @Ma27