Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force fill/stroke color at used value time #26601

Merged
merged 1 commit into from Nov 21, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 21, 2020

Forced colors should now happen at used value time. This change adjusts
the used value of fill, stroke, -internal-visited-fill, and
-internal-visited-stroke to take forced colors into account. No internal
properties were needed since we only ever force fill and stroke to one
value in forced colors mode.

The other forced color properties will be moved in follow up changes.

Note: This change will result in some functional differences with the
current fill/stroke behavior in forced colors mode. SVG elements have
"forced-color-adjust:none" set. Previously, SVG elements could inherit
forced colors from their ancestors. Now, since we force at used value
time, the used value of fill/stroke for SVG elements can no longer
inherit forced colors (unless "forced-color-adjust:auto" is set by
the author).

The related web tests have been updated to reflect this change in
behavior.

Bug: 970285
Change-Id: I5bcc498a67dbd49d7b319f7f079d062d73586013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515228
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829948}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Forced colors should now happen at used value time. This change adjusts
the used value of fill, stroke, -internal-visited-fill, and
-internal-visited-stroke to take forced colors into account. No internal
properties were needed since we only ever force fill and stroke to one
value in forced colors mode.

The other forced color properties will be moved in follow up changes.

Note: This change will result in some functional differences with the
current fill/stroke behavior in forced colors mode. SVG elements have
"forced-color-adjust:none" set. Previously, SVG elements could inherit
forced colors from their ancestors. Now, since we force at used value
time, the used value of fill/stroke for SVG elements can no longer
inherit forced colors (unless "forced-color-adjust:auto" is set by
the author).

The related web tests have been updated to reflect this change in
behavior.

Bug: 970285
Change-Id: I5bcc498a67dbd49d7b319f7f079d062d73586013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515228
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829948}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants