Force fill/stroke color at used value time #26601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forced colors should now happen at used value time. This change adjusts
the used value of fill, stroke, -internal-visited-fill, and
-internal-visited-stroke to take forced colors into account. No internal
properties were needed since we only ever force fill and stroke to one
value in forced colors mode.
The other forced color properties will be moved in follow up changes.
Note: This change will result in some functional differences with the
current fill/stroke behavior in forced colors mode. SVG elements have
"forced-color-adjust:none" set. Previously, SVG elements could inherit
forced colors from their ancestors. Now, since we force at used value
time, the used value of fill/stroke for SVG elements can no longer
inherit forced colors (unless "forced-color-adjust:auto" is set by
the author).
The related web tests have been updated to reflect this change in
behavior.
Bug: 970285
Change-Id: I5bcc498a67dbd49d7b319f7f079d062d73586013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515228
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829948}