Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5: 5.15.0 -> 5.15.2 #104448

Closed
wants to merge 5 commits into from
Closed

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Qt5.15.1 brought 400 bug fixes and Qt5.15.2 anoyther batch of 176, so let's take advantage of it.

Update done using the script in maintainers/scripts

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

Follow-up to #102216. Please see the comments there. Patches are probably needed as well.

@FRidh FRidh added this to the 20.09 milestone Nov 21, 2020
@poelzi
Copy link
Member

poelzi commented Nov 26, 2020

I have regular crashes in some programs because auf 5.15.0 regressions.

@poelzi poelzi mentioned this pull request Nov 26, 2020
10 tasks
@freezeboy
Copy link
Contributor Author

Maybe it is safer to close this one

@freezeboy freezeboy closed this Nov 26, 2020
@unclechu
Copy link
Member

@freezeboy Sorry, could you clarify please why did you close it?

@FRidh FRidh reopened this Nov 26, 2020
@freezeboy
Copy link
Contributor Author

As the other pr is struggling with the patches i guess this one is not worth the effort

@poelzi
Copy link
Member

poelzi commented Nov 26, 2020

It does not make sense to go to 5.15.1 when 5.15.2 is already available.

@ttuegel
Copy link
Member

ttuegel commented Dec 5, 2020

Qt 5.15.1 has some serious regressions (reported by Plasma upstream) and I would strongly prefer to go straight to Qt 5.15.2.

@freezeboy
Copy link
Contributor Author

@ttuegel Ok for me but I can't run nixpkgs-review, so if someone can check this version is ok, it will help.

I rebased on my machine and started a build of qt5 to be sure that at least the lib is building

@ttuegel
Copy link
Member

ttuegel commented Dec 5, 2020

I can't run nixpkgs-review, so if someone can check this version is ok, it will help.

I'm building now. The staging branch is badly broken right now, so I cherry-picked onto master for testing. If it works there, I'd say it's good enough to go into staging.

@FRidh FRidh mentioned this pull request Dec 7, 2020
4 tasks
@poelzi
Copy link
Member

poelzi commented Dec 9, 2020

Whats the progress here ? I have regular crashes due this buggy qt 5.15.0 and I start to get really annoyed by the slow progress of getting patch level updates into the tree.
Despite the fact I love nix, this is an perfect example why major distributions like ubuntu are way more stable and enterprise ready then NixOS and I can only suggest it with half a heart and will mention pain like this will come to everyone interested in nixos..... unfortuntelly :-/

@freezeboy
Copy link
Contributor Author

I didn't receive any feedback from the build process, so still waiting in case there is a problem.

@ttuegel
Copy link
Member

ttuegel commented Dec 9, 2020

I'm going to close this in favor of #106118. We should consolidate our efforts there because it is the most complete of the Qt 5.15 update pull requests.

@ttuegel ttuegel closed this Dec 9, 2020
@freezeboy freezeboy deleted the update-qt5.15.2 branch December 10, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants