Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1651776] aspect-ratio should be used for abspos when insets on the block axis are specified. #26600

Merged
merged 1 commit into from Nov 21, 2020

Conversation

moz-wptsync-bot
Copy link
Collaborator

Based on w3c/csswg-drafts#5151,
if the block size is auto, we still can use the insets to resolve the auto
block size on absoluate position elements, so we still can use this resolved
block size to calculate the inline size through aspect-ratio.

Differential Revision: https://phabricator.services.mozilla.com/D96277

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1651776
gecko-commit: e65987e878dcebc6a8e07bace669082bc3386fbe
gecko-reviewers: TYLin

…are specified.

Based on w3c/csswg-drafts#5151,
if the block size is auto, we still can use the insets to resolve the auto
block size on absoluate position elements, so we still can use this resolved
block size to calculate the inline size through aspect-ratio.

Differential Revision: https://phabricator.services.mozilla.com/D96277

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1651776
gecko-commit: e65987e878dcebc6a8e07bace669082bc3386fbe
gecko-reviewers: TYLin
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit e89a0c3 into master Nov 21, 2020
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1651776 branch November 21, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants