[staging] asciidoctor: add revealjs support #104404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since this change causes over 500 rebuilds, do you mind targeting the staging branch then change the base branch in the github PR from See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch |
bjornfor
force-pushed
the
asciidoctor-revealjs
branch
from
66b9666
to
94843c3
Compare
bjornfor
requested review from
alyssais,
cdepillabout,
Ericson2314,
FRidh,
jonringer,
matthewbauer,
stigtsp and
thoughtpolice
as code owners
bjornfor
force-pushed
the
asciidoctor-revealjs
branch
from
94843c3
to
748ba38
Compare
This allows creating HTML presentations with `asciidoctor-revealjs presentation.adoc`. NOTE: The generated HTML file implicitly depend on reveal.js (and I see no good way to bundle it with Nix). Either provide reveal.js in a local path next to the generated HTML file[1], or override the revealjsdir attribute, for example by pointing to an URL (can also be a path): asciidoctor-revealjs -a revealjsdir=https://cdn.jsdelivr.net/npm/reveal.js@3.9.2 presentation.adoc Implementation details: 1. Added "gem 'asciidoctor-revealjs'" to the Gemfile. 2. Ran "nix-shell -p bundler --run 'bundle lock --update'" from pkgs/tools/typesetting/asciidoctor/. 3. Hand edited Gemfile.lock to remove all but the asciidoctor-revealjs changes. (Rationale: allow backporting to release-20.09.) 4. Finish off with "nix-shell -p bundix --run 'bundix'". [1] Of course Nix can help with _that_, but that's external to the asciidoctor-revealjs program.
bjornfor
force-pushed
the
asciidoctor-revealjs
branch
from
748ba38
to
d9c2e1d
Compare
Done. (Wow, I didn't expect this to be a mass-rebuild.) |
|
it's used to generate docs for a lot of packages |
jonringer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows creating HTML presentations with
asciidoctor-revealjs presentation.adoc.NOTE: The generated HTML file implicitly depend on reveal.js (and I see
no good way to bundle it with Nix). Either provide reveal.js in a local
path next to the generated HTML file[1], or override the revealjsdir
attribute, for example by pointing to an URL (can also be a path):
asciidoctor-revealjs -a revealjsdir=https://cdn.jsdelivr.net/npm/reveal.js@3.9.2 [..]
Implementation details:
from pkgs/tools/typesetting/asciidoctor/.
changes. (Rationale: allow backporting to release-20.09.)
[1] Of course Nix can help with that, but that's external to the
asciidoctor-revealjs program.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after). Result: 323.0M -> 329.6M.