Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] python3Packages.jaraco*: fix namespace issues, fix ceph #104405

Merged
merged 10 commits into from Nov 23, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 20, 2020

Motivation for this change

closes #104047
closes #104082

cc @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

[10:58:14] jon@nixos ~/projects/nixpkgs (fix-jaraco-pkgs)
$ nix-build -E 'with import ./. { config = {}; overlays = []; }; python3.withPackages (ps: with ps; [ jaraco_functools jaraco_collections])'
/nix/store/hz147pqfvgdxrr3qwimazag4yvabkx4w-python3-3.8.6-env
[10:58:15] jon@nixos ~/projects/nixpkgs (fix-jaraco-pkgs)

@jonringer jonringer changed the title [staging] python3Packages.jaraco*: fix namespace issues [staging] python3Packages.jaraco*: fix namespace issues, fix ceph Nov 20, 2020
@jonringer jonringer mentioned this pull request Nov 20, 2020
10 tasks
@jonringer
Copy link
Contributor Author

trying to get ceph to build again... it's build dependency graph is unfortunately massive

@jonringer
Copy link
Contributor Author

I was able to build ceph

[14:20:44] jon@nixos ~/projects/nixpkgs (fix-jaraco-pkgs)
$ nix-build -A ceph
/nix/store/hfm0nvysyp9am0c2fjxpfzpqjcd6bv1y-ceph-15.2.5
[14:20:47] jon@nixos ~/projects/nixpkgs (fix-jaraco-pkgs)

Copy link
Contributor

@aij aij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jonringer
Copy link
Contributor Author

removed pytest-testmon revert, as this was added in #103958 . Rebased on latest staging. going to re-verify that ceph still builds, then merge

@jonringer
Copy link
Contributor Author

I was able to build ceph, and ofborg ran successfully locally

[08:27:33] jon@nixos ~/projects/nixpkgs (fix-jaraco-pkgs)
$ GC_INITIAL_HEAP_SIZE=16g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true --show-trace > out-paths
[08:30:46] jon@nixos ~/projects/nixpkgs (fix-jaraco-pkgs)

@jonringer jonringer merged commit 31b7ef7 into NixOS:staging Nov 23, 2020
@jonringer jonringer deleted the fix-jaraco-pkgs branch November 23, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants