Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.astropy: fix build #104418

Merged
merged 1 commit into from Nov 23, 2020
Merged

python3Packages.astropy: fix build #104418

merged 1 commit into from Nov 23, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 20, 2020 •
edited

Motivation for this change

noticed it was failing reviewing another PR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from KentJames November 20, 2020 21:18
@bcdarwin
Copy link
Member 

https://github.com/NixOS/nixpkgs/pull/104418
6 packages failed to build:
python37Packages.aplpy python37Packages.reproject python37Packages.spectral-cube python38Packages.aplpy python38Packages.reproject python38Packages.spectral-cube

20 packages built:
python37Packages.asdf python37Packages.astropy python37Packages.astropy-healpix python37Packages.astroquery python37Packages.pyavm python37Packages.pyregion python37Packages.pytest-astropy python37Packages.pytest-astropy-header python37Packages.radio_beam python37Packages.sunpy python38Packages.asdf python38Packages.astropy python38Packages.astropy-healpix python38Packages.astroquery python38Packages.pyavm python38Packages.pyregion python38Packages.pytest-astropy python38Packages.pytest-astropy-header python38Packages.radio_beam python38Packages.sunpy

bcdarwin
bcdarwin approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks fine to me (new deps are listed as required in the pyproject.toml).

@jonringer
Copy link
Contributor Author

all of the reverse dependencies were previously failing.

@jonringer jonringer merged commit a3ab7a3 into NixOS:master Nov 23, 2020
@jonringer jonringer deleted the fix-astropy branch November 23, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin bcdarwin approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@KentJames KentJames Awaiting requested review from KentJames

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @bcdarwin