Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/syncoid: fix permissions without --no-sync-snap #104420

Merged
merged 2 commits into from May 22, 2021
Merged

nixos/syncoid: fix permissions without --no-sync-snap #104420

merged 2 commits into from May 22, 2021

Conversation

danielfullmer
Copy link
Contributor

@danielfullmer danielfullmer commented Nov 20, 2020 •
edited

After 733acfa, syncoid would fail to
run if commonArgs did not include [ "--no-sync-snap" ], since it would
not have permissions to create or destroy snapshots.

CC @lopsided98

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lopsided98
lopsided98 suggested changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you guess what argument every command in my config has... :)

nixos/modules/services/backup/syncoid.nix Outdated Show resolved Hide resolved
@danielfullmer
nixos/syncoid: fix permissions without --no-sync-snap
d87903a 
After 733acfa, syncoid would fail to
run if commonArgs did not include [ "--no-sync-snap" ], since it would
not have permissions to create or destroy snapshots.
lopsided98
lopsided98 suggested changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this some more, I would rather test both with and without --no-sync-snap. I have implemented it here: lopsided98@7052ab7, if you want to pull it into this PR.

lopsided98
lopsided98 approved these changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bhipple, since you reviewed #79759, which this PR fixes.

@danielfullmer
Copy link
Contributor Author

@lopsided98 Also fixed a small typo in your commit message: s/synoid/syncoid/

@lopsided98
Copy link
Contributor

@ofborg test sanoid

@lopsided98 lopsided98 mentioned this pull request May 20, 2021
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit 7be85b5 into NixOS:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopsided98 lopsided98 lopsided98 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielfullmer @lopsided98 @SuperSandro2000