Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] mutt: 1.14.6 -> 2.0.2 #104423

Closed
wants to merge 4 commits into from
Closed

[20.03] mutt: 1.14.6 -> 2.0.2 #104423

wants to merge 4 commits into from

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 20, 2020

Motivation for this change

Backport of #104399, fixes CVE-2020-28896

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Cc: @matthiasbeyer

@matthiasbeyer @stigtsp
mutt: 1.14.6 -> 1.14.7
bacb3fa 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 91116f2)
@matthiasbeyer @stigtsp
mutt: 1.14.7 -> 2.0.0
df1b504 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit e9e003e)
@matthiasbeyer @stigtsp
mutt: 2.0.0 -> 2.0.1
57b0390 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 5848e98)
@matthiasbeyer @stigtsp
mutt: 2.0.1 -> 2.0.2
b363527 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit ad9256d)
@stigtsp stigtsp requested review from rnhmjoj and Ma27 November 20, 2020 21:50
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 20, 2020

I don't think it's a good idea to backport 2.0: it has enough breaking changes that it has been added to the 21.03 release notes.
If possible, I'd look into patching it with just this bug fix instead.

@Ma27
Copy link
Member

Ma27 commented Nov 20, 2020

Sounds reasonable. The patch didn't seem to hard (in case of neomutt) to apply, so I already did this on 20.03 for neomutt: c2967ae

@stigtsp stigtsp mentioned this pull request Nov 22, 2020
Merged
10 tasks
@stigtsp
Copy link
Member Author

stigtsp commented Nov 22, 2020

Closing in favour of doing a new PR with a patch.

@stigtsp stigtsp closed this Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stigtsp @rnhmjoj @Ma27 @matthiasbeyer