Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] mutt: 1.14.7 -> 2.0.2 #104422

Merged
merged 3 commits into from Nov 22, 2020
Merged

[20.09] mutt: 1.14.7 -> 2.0.2 #104422

merged 3 commits into from Nov 22, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 20, 2020

Motivation for this change

Backport of #104399, fixes CVE-2020-28896

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Cc: @matthiasbeyer

@matthiasbeyer @stigtsp
mutt: 1.14.7 -> 2.0.0
c9ef67d 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit e9e003e)
@matthiasbeyer @stigtsp
mutt: 2.0.0 -> 2.0.1
bd9547c 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 5848e98)
@matthiasbeyer @stigtsp
mutt: 2.0.1 -> 2.0.2
e205534 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit ad9256d)
@stigtsp stigtsp requested review from rnhmjoj and Ma27 November 20, 2020 21:43
@stigtsp stigtsp changed the title [20.09] mutt: 1.14.8 -> 2.0.2 [20.09] mutt: 1.14.7 -> 2.0.2 Nov 20, 2020
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 104422 1

2 packages built:
  • grepm
  • mutt (mutt-with-sidebar)

@mweinelt mweinelt merged commit 1f86723 into NixOS:release-20.09 Nov 22, 2020
@stigtsp
Copy link
Member Author

stigtsp commented Nov 22, 2020

@mweinelt mutt probably shouldn't have been bumped, since 2.x introduces some breaking changes. (sorry, my mistake)

#104423 (comment)

Ok to revert the change and create a new PR apply the patch?

@stigtsp stigtsp mentioned this pull request Nov 22, 2020
Merged
@mweinelt
Copy link
Member

Uh yeah, I missed the major version bump. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stigtsp @mweinelt @FRidh @matthiasbeyer