Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jamomacore: remove as unmaintained #104446

Merged
merged 2 commits into from Jan 20, 2021
Merged

jamomacore: remove as unmaintained #104446

merged 2 commits into from Jan 20, 2021

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

This library is broken since years, upstream has no activity since 2015 for this library
I found one application using it which looks unmaintained also, so removed it too

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you rebase this branch on master to fix the eval error?

prusnak
prusnak requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ossia/i-score redirects to https://github.com/ossia/score which is totally alive (last commit is 11 hours ago).

I suggest renaming i-score to ossia-score and updating it to latest version (which does not seem to require jamomacore).

Then we can drop the jamomacore.

@freezeboy
Copy link
Contributor Author

I am ok to add this software, but:

  1. as the previous was broken since ages, I suppose nobody use it currently
  2. I am not sure what their "release" suffix a19 means, but from other tags I guess alpha, and the fetch phase doesn't work:
From https://github.com/ArashPartow/exprtk
 * [new branch]      master     -> origin/master
fatal: reference is not a tree: d312ba91419c9cb12c8279fd3a19096d39dfcb5e
Unable to checkout d312ba91419c9cb12c8279fd3a19096d39dfcb5e from https://github.com/ArashPartow/exprtk.

@prusnak
Copy link
Member

prusnak commented Nov 23, 2020

I am not sure what their "release" suffix a19 means, but from other tags I guess alpha, and the fetch phase doesn't work:

In that case I think it's best to wait for the 3.0.0 stable

@ajs124 ajs124 mentioned this pull request Dec 29, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member

@freezeboy please resolve the merge conflict.

@freezeboy
Copy link
Contributor Author

Rebased, i also gave another try to build ossia-score to follow @prusnak's idea but still no success apparently they don't provide all the files in the source tgz.

@SuperSandro2000 SuperSandro2000 merged commit 9fbb29e into NixOS:master Jan 20, 2021
@freezeboy freezeboy deleted the remove-jamomacore branch January 22, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@RaghavSood RaghavSood RaghavSood approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @SuperSandro2000 @prusnak @RaghavSood