Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iannix: 2016-01-31 -> 0.9.20-b #104447

Merged
merged 2 commits into from Nov 28, 2020
Merged

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Use an official release. This version still doesn't allow yet to migrate to Qt5.15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this branch on master to fix the eval error?

maintainers = [ stdenv.lib.maintainers.nico202 ];
license = licenses.lgpl3;
platforms = platforms.linux;
maintainers = [ maintainers.nico202 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = [ maintainers.nico202 ];
maintainers = with maintainers; [ nico202 ];

@nico202
Copy link
Contributor

nico202 commented Nov 23, 2020

@freezeboy Would you mind maintaining this package? I'm running NixOS only on an headless server now

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104447 1

1 package built:
  • iannix

@doronbehar doronbehar merged commit 439e5f5 into NixOS:master Nov 28, 2020
@freezeboy freezeboy deleted the update-iannix branch November 28, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants