Force border color at used value time #26598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 20, 2020
Forced colors should now happen at used value time. This change adds an internal property to store the forced colors value of border-color. This internal value is then applied to the visited /unvisited border-bottom-color, border-top-color, border-right-color and border-left-color at used value time when appropriate. The other forced color properties will be moved in follow up changes. Bug: 970285 Change-Id: If2da52205595edf38b5009adaedcb0008c87d0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511858 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#829899}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2511858
branch
from
fb6666a
to
f72b921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forced colors should now happen at used value time. This change adds
an internal property to store the forced colors value of
border-color. This internal value is then applied to the visited
/unvisited border-bottom-color, border-top-color, border-right-color
and border-left-color at used value time when appropriate.
The other forced color properties will be moved in follow up changes.
Bug: 970285
Change-Id: If2da52205595edf38b5009adaedcb0008c87d0e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511858
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829899}