Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opustags: 1.4.0 -> 1.5.1, mark broken darwin #104788

Merged
merged 4 commits into from Jan 3, 2021

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

Motivation for this change

Closes #103484

Fails on darwin with

�[1m/tmp/nix-build-opustags-1.5.0.drv-0/source/src/system.cc:182:13: �[0m�[0;1;31merror: �[0m�[1mno member named 'st_mtim' in 'stat'�[0m
        mtime = st.st_mtim; // more precise than st_mtime
�[0;1;32m                ~~ ^
�[0m1 error generated.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104788 run on x86_64-linux 1

1 package built:
  • opustags

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 24, 2020
@ofborg ofborg bot requested a review from kmein November 24, 2020 19:19
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 26, 2020 00:16
@SuperSandro2000 SuperSandro2000 force-pushed the auto-update/opustags branch 2 times, most recently from bd28f6d to ead7e88 Compare November 26, 2020 00:33
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104788 run on x86_64-linux 1

1 package built:
  • opustags

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review December 4, 2020 02:07
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 104788 run on x86_64-linux 1

1 package built:
  • opustags

@SuperSandro2000 SuperSandro2000 merged commit 7ce2c5a into NixOS:master Jan 3, 2021
@SuperSandro2000 SuperSandro2000 deleted the auto-update/opustags branch January 3, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants