Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mopidy-subidy: init at 1.0.0 #104772

Merged
merged 1 commit into from Feb 8, 2021
Merged

mopidy-subidy: init at 1.0.0 #104772

merged 1 commit into from Feb 8, 2021

Conversation

wenngle
Copy link
Member

@wenngle wenngle commented Nov 24, 2020 •
edited

Motivation for this change

Mopidy-Subidy is a subsonic backend for Mopidy using the py-sonic library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Nov 24, 2020
View reviewed changes
pkgs/applications/audio/mopidy/subidy.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mopidy/subidy.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mopidy/subidy.nix Outdated Show resolved Hide resolved
@wenngle
Copy link
Member Author

wenngle commented Nov 24, 2020

Thank you for your feedback. I've updated my commit with the issues addressed.

@rnhmjoj rnhmjoj mentioned this pull request Nov 25, 2020
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/409

@wenngle wenngle force-pushed the mopidy-subidy branch 3 times, most recently from dbfde31 to 9b82b14 Compare December 19, 2020 01:08
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104772 run on x86_64-linux 1

1 package built:
  • mopidy-subidy

SuperSandro2000
SuperSandro2000 reviewed Dec 19, 2020
View reviewed changes
pkgs/applications/audio/mopidy/subidy.nix Outdated
description = "Mopidy extension for playing music from a Subsonic-compatible Music Server";
license = licenses.bsd3;
maintainers = with maintainers; [ wenngle ];
hydraPlatforms = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why shouldn't it be build on the hydra?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a mistake; I initially used one of the other Mopidy extensions as a template for this one.

SuperSandro2000
SuperSandro2000 reviewed Feb 8, 2021
View reviewed changes
pkgs/applications/audio/mopidy/subidy.nix Outdated
sha256 = "0c5ghhhrj5v3yp4zmll9ari6r5c6ha8c1izwqshvadn40b02q7xz";
};

propagatedBuildInputs = [ mopidy pythonPackages.py-sonic];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
propagatedBuildInputs = [ mopidy pythonPackages.py-sonic];
propagatedBuildInputs = [ mopidy pythonPackages.py-sonic ];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I've fixed it.

@SuperSandro2000

This comment has been minimized.

Sign in to view
1 similar comment
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104772 run on x86_64-darwin 1

1 package built:
  • mopidy-subidy

@SuperSandro2000 SuperSandro2000 merged commit d035f2f into NixOS:master Feb 8, 2021
@wenngle wenngle deleted the mopidy-subidy branch February 8, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil

@nbp nbp Awaiting requested review from nbp

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wenngle @nixos-discourse @SuperSandro2000