Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.*: unbreak glirc/matterhorn/QuickCheck/etc #104770

Merged
merged 7 commits into from Nov 27, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Nov 24, 2020

Motivation for this change

they were broken or marked broken and at least two people use a few of them :)

Things done

i fixed them and marked them not broken
tested glirc and matterhorn (now on macos as well)

mattermost-api{-qc} weren't even actually broken? shrug

am trying to compile them for macos but that might take a while... (glirc worked waiting on matterhorn) and doing nixpkgs-review on aarch64 because why not? (found out why; it doesn't work!)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

haskellPackages.mattermost-api: unbreak
haskellPackages.mattermost-api-qc: unbreak
Copy link
Member Author

@Kiwi Kiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: this was supposed to show up as being related to this; 34ae98d and it's bs that I can't ask myself to make changes @github

Should these have been in two different commits so that ofborg could build both of them? (it does build them when I name the commit properly, which I think it is, doesn't it? or not because haskell. or maybe not because of multiple commits? it only seems to check one...)

I guess If I had put them in the right order, assuming they do get built, it would still be fine and have to build them both because config-schema depends on config-value so would build it. That was my plan but I had it the other way around and thought config-value depended on config-schema.

Anyway I have built everything on darwin, nixos, and aarch64 nixos. so it should be fine.

@cdepillabout
Copy link
Member

Thanks for these changes. This looks good so I am merging in.


I did have one question though just out of curiosity. In matterhorn-chat/matterhorn#679 you said that you don't actually use matterhorn. However if I remember correctly, you're always the one that updates/fixes it in nixpkgs. Why do you fix it if you don't use it?

@cdepillabout cdepillabout merged commit d13b61b into NixOS:haskell-updates Nov 27, 2020
@Kiwi
Copy link
Member Author

Kiwi commented Nov 27, 2020

gotta pump up my PR numbers if I ever want to get commit bit! 😈

earlier on Discord:

@cdepillabout can we just assume that anything i fix is going to require the overrides forever ;_;
not that i don't like inflating my PR count with essentially the same PRs every few weeks...
"so kiwi what makes you think you're qualified to be a nixpkgs committer?" "well I've made 800 prs to these 3 packages on nixpkgs" "..." "can haz commit?"

More seriously though @evils uses it and I'm sure other people do too and he does most of the work on Kicad so it's the least I could do for him. and who knows, maybe I'll want to use it someday and I won't even have to fix/package it first when I do! 😄 . I like to make sure things work and are available in nixpkgs and that goes a lot smoother if there's at least, and preferably more than, one maintainer listed. Not all maintainers are even that active. or around at all. So when I find something that's been broken for a while or I am interested in using or if I just want to take on some of the work (hi @florianjacob) to get things done quicker (I have a lot of free time and nothing to do) I'll fix/upgrade/package it and put my name down. If nobody else has done it by the time I do it then who knows if or when something will work again. (like the bitwarden-desktop client, a few znc plugins i needed to replace my freebsd server, MLV.APP, and simplenote I wanted to try and had to package) So if I can figure it out I do it.. "No Issues, only PRs!" 😛 . ...I still need to make a few of those work on darwin now that I have a builder...

...Sometimes I'll fix something that breaks in nixos-unstable and come to make the PR and there is already one, other times it's been weeks or months without attention. I think at least half a dozen people tried getting ocrmypdf packaged before I did... it took me a few months and I've never used it other than to test but I know other people do because they file issues when it breaks. lol (I have used the program but the one PDF I needed it for I processed with the brew package on macos while I was getting used to NixOS in a VM on my laptop and an old desktop someone was throwing away). That's also how I ended up having nixops-digitalocean 😢 It got axed when nixops 2 went with the plugin system and nobody had converted it to a plugin for a few months and so I gave it a shot... anyway...

tl;dr: somebody's gotta do it and if I can figure it out and have time (I usually do) then it might as well be me because if I don't maybe no-one will and it gives me something to do and a way to help. same reason I'm making all of these stickers to give maintainers (hi @jonringer)

@cdepillabout
Copy link
Member

Well thanks for spending the time to get this stuff working!

@Kiwi Kiwi deleted the fixes branch December 13, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants