Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nullmailer: add missing directory /var/spool/nullmailer/failed #104800

Closed
wants to merge 1 commit into from
Closed

nixos/nullmailer: add missing directory /var/spool/nullmailer/failed #104800

wants to merge 1 commit into from

Conversation

franksergeant
Copy link

Without the /var/spool/nullmailer/failed directory, failed messages stay
in /var/spool/nullmailer/queue, but should not.

Motivation for this change

When a message fails, nullmailer should move it from the 'queue' directory to the 'failed' directory, but it cannot because the 'failed' directory does not exist.

See issue #104413 for more details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [y] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [y ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

But I suspect I am not doing this correctly.

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 67, done.
remote: Counting objects: 100% (67/67), done.
remote: Compressing objects: 100% (31/31), done.
remote: Total 84 (delta 53), reused 43 (delta 36), pack-reused 17
Unpacking objects: 100% (84/84), 164.08 KiB | 4.43 MiB/s, done.
From https://github.com/NixOS/nixpkgs
 * [new branch]              master     -> refs/nixpkgs-review/0
$ git worktree add /home/frank/.cache/nixpkgs-review/rev-119a27a5494127f0d47c2241cccff6d413669c5b-dirty/nixpkgs 0be35abecdffc532173524de5a86984780088a07
Preparing worktree (detached HEAD 0be35abecdf)
Updating files: 100% (23295/23295), done.
HEAD is now at 0be35abecdf Merge pull request #104319 from magnetophon/m32edit
$ nix-env -f /home/frank/.cache/nixpkgs-review/rev-119a27a5494127f0d47c2241cccff6d413669c5b-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@franksergeant
"nixos/nullmailer: add missing directory /var/spool/nullmailer/failed
119a27a 
Without the /var/spool/nullmailer/failed directory, failed messages stay
in /var/spool/nullmailer/queue, but should not.
@roberth roberth changed the base branch from nixos-20.09 to release-20.09 February 1, 2021 22:16
@roberth roberth requested a review from sargon February 1, 2021 22:16
@roberth roberth changed the title "nixos/nullmailer: add missing directory /var/spool/nullmailer/failed nixos/nullmailer: add missing directory /var/spool/nullmailer/failed Feb 1, 2021
@mweinelt
Copy link
Member

mweinelt commented Jul 5, 2021

Unfortunately NixOS 20.09 has reached its end-of-life status on 2021-07-01, one
month after the release of NixOS 21.05.

Since we do not accept any changes to its branches anymore, I'm closing this pull
request.

@mweinelt mweinelt closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sargon sargon Awaiting requested review from sargon

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franksergeant @mweinelt @Janik-Haag