Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moosefs: fix mfscli #104766

Merged
merged 1 commit into from Nov 24, 2020
Merged

moosefs: fix mfscli #104766

merged 1 commit into from Nov 24, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change

python in buildInputs fixes automatically mfscli and mfscgiserv (both are python code).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
moosefs: fix mfscli
53fa857 
python in buildInputs fixes automatically mfscli and mfscgiserv.
@markuskowa markuskowa merged commit 44db0e8 into NixOS:master Nov 24, 2020
@markuskowa markuskowa deleted the fix-moosefs branch November 24, 2020 16:00
@markuskowa markuskowa added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 24, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104766 run on x86_64-linux 1

1 package built:
  • moosefs

@markuskowa
Copy link
Member Author

Back ported to 20.09 in fd2044d

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfossen mfossen mfossen approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @SuperSandro2000 @mfossen @erictapen