Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sssd: fix build on glibc-2.32 #104774

Merged
merged 1 commit into from Nov 24, 2020
Merged

sssd: fix build on glibc-2.32 #104774

merged 1 commit into from Nov 24, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 24, 2020

For https://hydra.nixos.org/build/128488320 which errored with:

src/responder/nss/nss_cmd.c:733:16: error: 'nss_setnetgrent' redeclared as different kind of symbol
  733 | static errno_t nss_setnetgrent(struct cli_ctx *cli_ctx,
      |                ^~~~~~~~~~~~~~~
In file included from ./src/sss_client/sss_cli.h:28,
                 from ./src/db/sysdb.h:27,
                 from src/responder/nss/nss_cmd.c:26:
/nix/store/a2n8nrsf215x01a7fv8l94crdjwf69pa-glibc-2.32-dev/include/nss.h:184:25: note: previous declaration of 'nss_setnetgrent' was here
  184 | typedef enum nss_status nss_setnetgrent (const char *, struct __netgrent *);
      |                         ^~~~~~~~~~~~~~~
make[2]: *** [Makefile:17818: src/responder/nss/nss_cmd.o] Error 1
make[2]: Leaving directory '/build/sssd-1.16.4'
make[1]: *** [Makefile:33824: all-recursive] Error 1
make[1]: Leaving directory '/build/sssd-1.16.4'
make: *** [Makefile:10123: all] Error 2
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

For https://hydra.nixos.org/build/128488320 which errored with:

    src/responder/nss/nss_cmd.c:733:16: error: 'nss_setnetgrent' redeclared as different kind of symbol
      733 | static errno_t nss_setnetgrent(struct cli_ctx *cli_ctx,
          |                ^~~~~~~~~~~~~~~
    In file included from ./src/sss_client/sss_cli.h:28,
                     from ./src/db/sysdb.h:27,
                     from src/responder/nss/nss_cmd.c:26:
    /nix/store/a2n8nrsf215x01a7fv8l94crdjwf69pa-glibc-2.32-dev/include/nss.h:184:25: note: previous declaration of 'nss_setnetgrent' was here
      184 | typedef enum nss_status nss_setnetgrent (const char *, struct __netgrent *);
          |                         ^~~~~~~~~~~~~~~
    make[2]: *** [Makefile:17818: src/responder/nss/nss_cmd.o] Error 1
    make[2]: Leaving directory '/build/sssd-1.16.4'
    make[1]: *** [Makefile:33824: all-recursive] Error 1
    make[1]: Leaving directory '/build/sssd-1.16.4'
    make: *** [Makefile:10123: all] Error 2
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 24, 2020

Result of nixpkgs-review pr 104774 run on x86_64-linux 1

1 package failed to build:
  • autofs5
1 package built:
  • sssd

Build failure looks unrelated to this PR. Going to fix it in a separate PR.

@grahamc
Copy link
Member Author

grahamc commented Nov 24, 2020

Thanks, @SuperSandro2000 !

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2020

We can just fetchpatch SSSD/sssd@fe9eeb5 its fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants