Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive: Use lib.unique for uniqueness checks #104773

Merged
merged 1 commit into from Nov 24, 2020
Merged

texlive: Use lib.unique for uniqueness checks #104773

merged 1 commit into from Nov 24, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Nov 24, 2020 •
edited

In 85605c8 we got a really nice performance improvement.

By using this implementation for texlive instantiation RSS is cut by ~2.6x with a similar wall time speedup.

Performance was checked with:
time -f '%M %e' nix-instantiate '<nixpkgs>' -A texlive.combined.scheme-full --dry-run

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @edolstra

@adisbladis
texlive: Use lib.unique for uniqueness checks
ce84cc0 
In 85605c8 we got a really nice
performance improvement.

By using this implementation for texlive instantiation RSS is cut by
~2.6x with a similar wall time speedup.
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 24, 2020
@ofborg ofborg bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Nov 24, 2020
@edolstra edolstra merged commit 4160889 into NixOS:master Nov 24, 2020
@adisbladis
Copy link
Member Author

Backported to 20.09 in ce84cc0.

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 24, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-5/10560/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra edolstra left review comments

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: TeX Issues regarding texlive and TeX in general 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adisbladis @nixos-discourse @veprbl @edolstra @spacekitteh @xaverdh