Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 5.0.2 -> 5.0.3 #104767

Merged
merged 1 commit into from
Nov 24, 2020
Merged

platformio: 5.0.2 -> 5.0.3 #104767

merged 1 commit into from
Nov 24, 2020
+17 −22

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Nov 24, 2020

Motivation for this change

Version bump.
In addition to the version change, the source is managed in a central location, since previously the same change had to be made in two places.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@oxzi
platformio: 5.0.2 -> 5.0.3

Verified

This commit was signed with the committer’s verified signature.
primeos Michael Weiss
GPG key ID: 5BE487C4D4771D83
Verified
Learn about vigilant mode
160c5e9 
In addition to the version change, the source is managed in a central
location, since previously the same change had to be made in two places.
@ofborg ofborg bot requested a review from mogorman November 24, 2020 14:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 24, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104767 run on x86_64-linux 1

2 packages built:
  • esphome
  • platformio

@SuperSandro2000 SuperSandro2000 merged commit 84fd681 into NixOS:master Nov 24, 2020
@oxzi oxzi deleted the platformio-5.0.3 branch November 24, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogorman mogorman

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxzi @SuperSandro2000