Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhallPackages.Prelude: 13.0.0 -> 19.0.0 #104780

Merged
merged 1 commit into from Nov 24, 2020
Merged

dhallPackages.Prelude: 13.0.0 -> 19.0.0 #104780

merged 1 commit into from Nov 24, 2020

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Nov 24, 2020 •
edited

Motivation for this change

The current version of the Dhall prelude is quite a ways behind. Is there any reason not to update this as soon as new releases come out? If the prelude is too far ahead then the dhall package should fail to normalize the prelude during the build.

cc @Gabriel439

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gabriella439
Copy link
Contributor

@ehmry: Yeah, it should be regularly updated. Part of what I'm doing right now is building the infrastructure to make that easier (including the dhall-to-nixpkgs utility)

@SuperSandro2000 SuperSandro2000 merged commit 9a2b5a9 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehmry @Gabriella439 @SuperSandro2000